Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs shifts size by 1px depending on number of items listed #1031

Open
anandamaryon1 opened this issue Sep 25, 2024 · 0 comments · May be fixed by #1032
Open

Breadcrumbs shifts size by 1px depending on number of items listed #1031

anandamaryon1 opened this issue Sep 25, 2024 · 0 comments · May be fixed by #1032
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@anandamaryon1
Copy link
Contributor

Bug Report

What is the issue?

Breadcrumbs in frontend release v9.0.0 shift by 1px when changing from 1 item to more than 1 item.

image
image

What steps are required to reproduce the issue?

Visit a 2nd level page eg: https://service-manual.nhs.uk/design-system and then navigate to a deeper page, eg: https://service-manual.nhs.uk/design-system/design-principles.

Observe that the breadcrumbs component grows from 24px to 25px, pushing the following page content down by 1px.

What was the environment where this issue occurred?

Checked on Mac: Chrome, Edge, Firefox and Safari. And Windows 11: latest Edge.

Is there anything else you think would like to say about this issue?

This was me and I'm sorry
@anandamaryon1 anandamaryon1 added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Sep 25, 2024
anandamaryon1 added a commit that referenced this issue Sep 25, 2024
@anandamaryon1
tweak breacrumb :after styles to fix: #1031
3433ce7
@anandamaryon1 anandamaryon1 linked a pull request Sep 25, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak breadcrumb :after styles to fix layout bug nhsuk/nhsuk-frontend
1 participant
@anandamaryon1