Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should use paragraphs rather than spans #1029

Open
edwardhorsford opened this issue Sep 24, 2024 · 0 comments · May be fixed by #1030
Open

Error message should use paragraphs rather than spans #1029

edwardhorsford opened this issue Sep 24, 2024 · 0 comments · May be fixed by #1030
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@edwardhorsford
Copy link
Contributor

Bug Report

Our error message component uses spans, where I think it should use paragraphs. I checked GOV.UK and it used to use spans prior to v4.0 - it was changed in this pr.

I suspect one consequence of this is that VoiceOver will read the error message in a less clear way.

With the gov.uk design system, VoiceOver reads the error message as one line: Error: The date your passport was issued must be in the past. With ours, it reads Error: on its own, and you have to manually advance to the next bit. I suspect this is because VoiceOver treats spans within a block level element as one thing, but when it's inline elements in inline elements it treats them separately.

@anandamaryon1 anandamaryon1 added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Sep 24, 2024
@edwardhorsford edwardhorsford linked a pull request Sep 24, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants