Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aib improve accessibility #137

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Aib improve accessibility #137

wants to merge 15 commits into from

Conversation

amaiaita
Copy link
Collaborator

@amaiaita amaiaita commented Sep 17, 2024

Description

What: accessibility improvements as follow ups from the accessibility review: https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?pageId=902212969

🧠Why?: important for our website to be accessible

👨‍💻How?: details of changes made are in the above confluence page

Checklist:

Have checked for the following:

  • The website still builds correctly, and you can view it using mkdocs serve.
  • There are no new "warnings" from mkdocs
  • Does your page follow the page template (or here in Markdown)? (need to make a new one specific to NHSE Data Science)
  • Spelling errors
  • Consistent capitalization
  • Consistent numbers
  • Material features incorrectly implemented: search for code blocks and markers (e.g. !!!).
  • Code snippets don't work
  • Images not working
  • Links not working

Where it was tested

  • Github Codespaces - 2-core, 4GB RAM, 32GB hard drive
  • devcontainer.json describes further settings

@amaiaita amaiaita marked this pull request as ready for review September 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant