Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with createLinkPlugin #58

Open
xiaoyunyang opened this issue Aug 8, 2018 · 1 comment
Open

Incompatibility with createLinkPlugin #58

xiaoyunyang opened this issue Aug 8, 2018 · 1 comment

Comments

@xiaoyunyang
Copy link

I want to be able to use both markdown shortcuts plugin and draft-js-anchor-plugin but it's impossible to get them to both work in creating a link. I think the problem is with the name used for the state. For the markdown plugin, it's href. For the anchor plugin, it's url.

Can we make the necessary revisions to get the markdown plugin to be compatible with the anchor plugin? I think at least this file definitely needs to be changed.

If that can't be done, is there a way we can disable a markdown shortcut from createMarkdownShortcutsPlugin()?

@vmc08
Copy link

vmc08 commented Feb 28, 2021

I think the problem is the component being rendered is only supplied with href and title, can the component still take other attributes? target, classes and etc.

Link for reference
https://github.com/ngs/draft-js-markdown-shortcuts-plugin/blob/631f1863341ee57cd3cd93c54d06b364562254da/src/components/Link/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants