join votes for participation check #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…w-redirects-1.15.6
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Register Services
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
…nto enh/join-votes Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
…nto enh/join-votes Signed-off-by: dartcafe <[email protected]>
Signed-off-by: dartcafe <[email protected]>
come-nc
reviewed
Mar 21, 2024
Comment on lines
+157
to
+165
| $context->registerService(UserMapper::class, function (ContainerInterface $c): UserMapper { | ||
| return new UserMapper( | ||
| $c->get(IDBConnection::class), | ||
| $c->get(ISession::class), | ||
| $c->get(IUserSession::class), | ||
| $c->get(IUserManager::class), | ||
| $c->get(LoggerInterface::class), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Is all this needed? This is the default DI behavior to my knowledge.
There was a problem hiding this comment.
I was annoyed by the unit tests, where every dependency needed to be instantiated.
If there is a DI possibility for the tests, this is indeed unnecessary.
There was a problem hiding this comment.
Usually you use Mocks for the tests
There was a problem hiding this comment.
Yeah. Tests. See #3147 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count current user's votes via join in poll
regarding #3362