Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed articles are not sorted by date #1608

Closed
3 tasks done
gsantner opened this issue Dec 8, 2021 · 12 comments
Closed
3 tasks done

Displayed articles are not sorted by date #1608

gsantner opened this issue Dec 8, 2021 · 12 comments
Labels

Comments

@gsantner
Copy link

gsantner commented Dec 8, 2021

IMPORTANT

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Articles shown in the frontend are not sorted by it's date, but instead of some import date / import ID and grouping.

Please see the video below, you can clearly see that there are articles once "x hours ago", then "days ago", then "hours ago" again, then somewhen "weeks ago"...
I do expect that WHATEVER the source of the news article is, is on top if it was published the most recently.

cut.mp4

This issue seems similar but was closed and stayed closed: #51

What I quickly tried is changing the OrderBy at nextcloud/apps/news/lib/Db/ItemMapperV2.php to pub_date, then the situation minimally improved, but guess thats the point where changes are needed.

Just for reference, this is how TT-RSS orders newest:

grafik

Steps to Reproduce

Explain what you did to encounter the issue

  1. Open news
  2. see the list is not ordered by date and I have to read OLD news first, before seeing other NEW news. Inverse - have to read NEW news, before seeing other OLD news of it!

System Information

  • News app version: 17.0.0
  • Nextcloud version: 22.2.3
  • Cron type: crontab
  • PHP version: 7.4
  • Database and version: mariadb 10
  • Browser and version: Any browser
  • OS and version: Any OS with a browser

Would be really cool if you can sort the news by date, instead of some ID made up on your own at database. It would be very fine if the user needs to check "sort by date" / toggle between ID and date, whatever is easiest and works
Thanks!

@gsantner gsantner added the bug label Dec 8, 2021
@Grotax
Copy link
Member

Grotax commented Dec 9, 2021

I think this needs to be handled by the client, for the api this should not matter.
Sorting is something for the human and preferences might be different.

So in the case of the old webapp the javascript would need to sort the items according to the users preference.

@gsantner
Copy link
Author

gsantner commented Dec 9, 2021

Agree that its a client thing, however in this project the web Frontend/"client" seems quite though coupled to the backend. like database queries on it's own. correct?

And yes, a user setting is OK and welcome.... whatever allpws to sort properly by date instead of some articleid and feed grouping.

@Grotax
Copy link
Member

Grotax commented Dec 10, 2021

Yea that's true, so far nobody managed to modernize the webapp, if it happens one day I think this should be part of that.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022
@chylex
Copy link
Contributor

chylex commented Jan 24, 2022

Seems editing nextcloud/custom_apps/news/lib/Db/ItemMapperV2.php does not work anymore, still getting wrong order when viewing a folder:

obrazek

@stale stale bot removed the stale label Jan 24, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 16, 2022
@chylex
Copy link
Contributor

chylex commented Apr 16, 2022

The issue is still relevant.

@stale stale bot removed the stale label Apr 16, 2022
@Grotax
Copy link
Member

Grotax commented Apr 16, 2022

Yea but I think it can be closed, the frontend urgently needs a complete rewrite as the technology it uses is no longer supported and bugs/security issues will stay open. If that is not done the problem will keep existing for forever.
If the frontend gets rebuild this issue will not be relevant anymore.

@Grotax Grotax closed this as completed Apr 16, 2022
@Grotax
Copy link
Member

Grotax commented Apr 16, 2022

Related to #195

@fazlerabbi37
Copy link

@Grotax maybe we can add this as todo/sub task for #195? This way it's not 'out of sight'.

@Grotax
Copy link
Member

Grotax commented Mar 29, 2023

You could write a comment there, but I fear it won't change much.

The frontend based on the original angular js, that is no longer supported.

The frontend needs to be rebuild with a new JavaScript framework, Vue js makes sense since Nextcloud provides common components for that and most internally (by the company) maintained apps use Vue now or soon.

There were attempts to do that but it's not that easy to do and currently there is again no ongoing progress.

@alesha1488
Copy link

please, fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants