feat: regen proto for Neutron Cron module #NTRN-339 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joldie777
force-pushed
the
feat/choose-cron-blocker
branch
from
e9ab301
to
45007a5
Compare
This was referenced Aug 14, 2024
pr0n00gler
requested changes
Aug 19, 2024
| name: String, | ||
| period: u64, | ||
| msgs: Vec<MsgExecuteContract>, | ||
| blocker: u64, |
There was a problem hiding this comment.
You've renamed blocker to ExecutionStage in go code. Let's do it everywhere. Also let's change a type of the argument in the method to BlockerType from cron.rs file.
Also do not forget to regenerate proto files
NeverHappened
previously approved these changes
Aug 21, 2024
|
please resolve conflicts |
sotnikov-s
previously approved these changes
Sep 3, 2024
NeverHappened
dismissed stale reviews from sotnikov-s and themself
via
c0f4e49
NeverHappened
force-pushed
the
feat/choose-cron-blocker
branch
from
c0f4e49
to
6164ce8
Compare
pr0n00gler
approved these changes
Sep 4, 2024
pr0n00gler
approved these changes
Sep 4, 2024
This was referenced Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://hadronlabs.atlassian.net/browse/NTRN-339
Related PRs:
neutron-org/neutron#671