Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and issues in fortinet_get_system_status for FortiGate 7.2 VM #1774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glennake
Copy link

No description provided.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @glennake

For updates to existing templates, the test data for those templates will need to be updated to reflect the changes.

For new templates, we require test cases be included in the PR, and we now require that every state provide a final line ^. -> Error to ensure that we are capturing the data.

@jmcgill298 jmcgill298 added changes_requested Waiting on user to address feedback New Template labels Jul 22, 2024
@mjbear
Copy link
Contributor

mjbear commented Aug 4, 2024

Thanks for the PR @glennake

For updates to existing templates, the test data for those templates will need to be updated to reflect the changes.

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#development-helper-scripts

For new templates, we require test cases be included in the PR,

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#tests
https://github.com/networktocode/ntc-templates/blob/master/docs/user/faq.md#i-simply-want-to-add-my-template-to-the-project-i-do-not-want-to-add-all-of-these-tests-and-controls-can-i-just-do-so

and we now require that every state provide a final line ^. -> Error to ensure that we are capturing the data.

https://github.com/networktocode/ntc-templates/blob/master/docs/user/faq.md#why-is-there-a-requirement-to-use-error-in-every-template

Hopefully the above hyperlinks to documentation helps.
🎯 There isn't much effort left from you @glennake to complete the requirements so this pull request (PR) could be reviewed and merged in!

@jmcgill298
Copy link
Contributor

@glennake are you still interested in seeing this PR completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change changes_requested Waiting on user to address feedback New Template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants