Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getPassportInstance as type for return value #1317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Add getPassportInstance as type for return value #1317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/passport/passport.strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function PassportStrategy<T extends Type<any> = any>(
Strategy: T,
name?: string | undefined
): {
new (...args): InstanceType<T>;
new (...args): InstanceType<T> & { getPassportInstance(): passport.PassportStatic };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/passport is not a required dependency. Isn't this change going to break projects where skipLibCheck is not set to true?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

image

We can work around that by adding
// @ts-expect-error TS2503: Cannot find namespace 'passport'
before that line

} {
abstract class MixinStrategy extends Strategy {
abstract validate(...args: any[]): any;
Expand Down