Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the filter AND/OR #252

Open
yarc opened this issue Nov 16, 2021 · 1 comment
Open

Bring back the filter AND/OR #252

yarc opened this issue Nov 16, 2021 · 1 comment
Labels
wait for answer Further information is requested

Comments

@yarc
Copy link

yarc commented Nov 16, 2021

Hi, i cannot upgrade from 1.2.0 to 1.4.0 without this feature and 1.2.0, as it is, is not performant enough with our data. Here are some fairly common use cases:

The user is offered a list of product price ranges (1-10$, 11-20$, 21-30$...). The user can select any of the price ranges. In a query this is where we would produce an OR for each selected ranges.

The user is viewing a schedule of events and is offered the option to filter the events by calendar date, of which he can select multiple (non-contiguous) dates. In the data each event has a timestamp associated. There would be one OR filter per selected date, that does a event.startTime > $day AND event.endTime < $day

Lastly, we often use the "AND" filter to be able to add multiple filters that are based off the same relation. If we do not use an AND in these cases, all duplicate filters overwrite each other and only the last relation filter is preserved. This is also due to the fact that we pass in dynamic filters as a graphql variable.

@Andy2003
Copy link
Collaborator

@yarc Can you please provide a testcase.

@Andy2003 Andy2003 added the wait for answer Further information is requested label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait for answer Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants