Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services menu in JLab has multiple behaviors #2711

Open
kcpevey opened this issue Sep 6, 2024 · 5 comments
Open

Services menu in JLab has multiple behaviors #2711

kcpevey opened this issue Sep 6, 2024 · 5 comments
Labels

Comments

@kcpevey
Copy link
Contributor

kcpevey commented Sep 6, 2024

Context

The services menu in JLab behaves differently based on which of the options you choose. Its disorienting for users when conda-store opens within the JLab window, but other options open in a new tab.

A solution would be to visually breakdown the services menu so users have a concept that the behavior is different.

Here is an initial design for this breakdown:
image

Value and/or benefit

Users have a visual indication that some services are different from others and therefore the result of clicking on them is not disorienting.

Anything else?

No response

@dharhas
Copy link
Member

dharhas commented Sep 6, 2024

"internal"/"External" isn't a good description of what these are.

@krassowski
Copy link
Member

krassowski commented Sep 6, 2024

The menu is currently defined in:

{
"id": "jp-mainmenu-services",
"disabled": false,
"label": "Services",
"rank": 1000,
"items": [
{
"command": "nebari:run-first-enabled",
"args": {
"commands": [
{
"id": "condastore:open",
"label": "Environment Management"
},
{
"id": "help:open",
"args": {
"url": "/conda-store",
"text": "Environment Management",
"newBrowserTab": true
}
}
]
},
"rank": 1
},
{
"command": "help:open",
"rank": 2,
"args": {
"url": "/auth/admin/nebari/console",
"text": "User Management",
"newBrowserTab": true
}
},
{
"command": "help:open",
"rank": 3,
"args": {
"url": "/monitoring",
"text": "Monitoring",
"newBrowserTab": true
}
},
{
"command": "help:open",
"rank": 4,
"args": {
"url": "/argo",
"text": "Argo Workflows",
"newBrowserTab": true
}
},
{
"command": "nebari:open-proxy",
"rank": 5,
"args": {
"name": "vscode"
}
}
]
},

Some functions are implemented in https://github.com/nebari-dev/jupyterlab-nebari-mode extension. For compatibility when jupyterlab-conda-store extension is disabled or not installed it will open the Environment Management tab externally in new tab.

@krassowski
Copy link
Member

We can add the divider easily. We can add non-clickable "Internal"/"External" entries. We can:

  • prepend icons
  • target individual menu items with CSS to customize it (it is a bit hacky but possible)

The problem will be if an admin disabled https://github.com/conda-incubator/jupyterlab-conda-store and now it does not open in JupyterLab.

I think I would prefer to change the menu items to show [↗] as the label can be set separately for the scenario when jupyterlab-conda-store is installed vs when it is not.

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Sep 6, 2024

I agree internal/external seems like the wrong labels. Conda store (Environment Management) is external to Nebari as well. It just happens to be developed by Quansight as well, but it's a separate open source project the same as Keycloak (User Management) or any of the others.

Update: I realize you mean internal/external windows, but it wouldn't have been clear to me without the explanation above.

@kcpevey
Copy link
Contributor Author

kcpevey commented Sep 6, 2024

I think I would prefer to change the menu items to show [↗]

I love this idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New 🚦
Development

No branches or pull requests

4 participants