Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTEL Metrics #316

Open
mtmk opened this issue Jan 10, 2024 · 2 comments · May be fixed by #629
Open

Add OTEL Metrics #316

mtmk opened this issue Jan 10, 2024 · 2 comments · May be fixed by #629
Assignees
@divyeshio
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mtmk
Copy link
Collaborator

mtmk commented Jan 10, 2024 •
edited
Loading

Proposed change

Move NatsConnection.GetStats() functionality to use https://learn.microsoft.com/dotnet/api/system.diagnostics.metrics APIs.

Use case

For example Aspire integration can expose these metrics

Contribution

Contributions are welcome
@mtmk mtmk added the enhancement New feature or request label Jan 10, 2024
@mtmk mtmk mentioned this issue Jan 10, 2024
Merged
5 tasks
@mtmk mtmk mentioned this issue Feb 14, 2024
Merged
@mtmk mtmk added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 27, 2024
@divyeshio
Copy link

Hi @mtmk , I'm willing to contribute for this, currently looking at how it is implemented in aspnetcore.

@mtmk
Copy link
Collaborator Author

mtmk commented Sep 10, 2024

Hi @mtmk , I'm willing to contribute for this, currently looking at how it is implemented in aspnetcore.

sounds great thanks @divyeshio feel free to open a PR

@divyeshio divyeshio linked a pull request Sep 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyeshio divyeshio

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add OTEL Metrics divyeshio/nats.net
2 participants
@mtmk @divyeshio