Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't sorted_set[non_existent_member] return nil instead of 0? #158

Open
snicky opened this issue Nov 17, 2014 · 2 comments
Open

Shouldn't sorted_set[non_existent_member] return nil instead of 0? #158

snicky opened this issue Nov 17, 2014 · 2 comments
Labels
help wanted more info

Comments

@snicky
Copy link

snicky commented Nov 17, 2014

I am aware of the change made in this PR: #68, although dont really understand why to keep 0 as the return value of calling sorted_set[non_existent_member]. It is a bit confusing that you have to handle a special case of 0 in your own code.
@phuongnd08
Copy link

I find the sorted_set#[] to be confusing. Why both range and score being accessed by the same method?

@nateware
Copy link
Owner

Open to any changes - @tmsrjs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nateware @phuongnd08 @snicky