pytest wrapper should return None, not result #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the wrapper does need the output of the wrapped function for processing, pytest complains for any test function that returns data. Updates the wrapper function that processes mocked data to not return the wrapped function result. Closes #2118
ktbyers
reviewed
Aug 2, 2024
| @@ -27,8 +27,6 @@ python_files = | |||
| test_*.py | |||
| *_test.py | |||
| tests.py | |||
| json_report = report.json | |||
| jsonapi = true | |||
There was a problem hiding this comment.
Were these two changes meant to be included in this?
There was a problem hiding this comment.
Yes, because pytest complained/printed warnings when they were present:
https://github.com/napalm-automation/napalm/actions/runs/9962394420/job/27526038035#step:8:729
There was a problem hiding this comment.
And I believe we pass these as command line options in the docs build: https://github.com/napalm-automation/napalm/blob/develop/docs/test.sh#L8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the wrapper does need the output of the wrapped function for processing, pytest complains for any test function that returns data.
Updates the wrapper function that processes mocked data to not return the wrapped function result.
Closes #2118