Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add an extension from ShadTheme.of(context) into context.shadTheme.textTheme #140

Open
moshOntong-IT opened this issue Sep 14, 2024 · 2 comments
Open

Feat: Add an extension from ShadTheme.of(context) into context.shadTheme.textTheme #140

moshOntong-IT opened this issue Sep 14, 2024 · 2 comments
Labels
waiting for customer response Cannot make further progress on this issue until the original reporter responds

Comments

@moshOntong-IT
Copy link
Contributor

Is this possible? if it is then I can PR.
@moshOntong-IT
Copy link
Contributor Author

#141

@nank1ro
Copy link
Owner

nank1ro commented Sep 16, 2024

I don't think it makes sense to add the extensions.
Because then the code would be half and half using the extensions and not using them.
I think this is the onus is on the user, who can add them in his project as he likes.
Then there would really be a lot of extensions, I would do as Flutter does which does not provide them, so then the user can build them as they wish.
Let me know what you think

@nank1ro nank1ro mentioned this issue Sep 16, 2024
Open
@nank1ro nank1ro added the waiting for customer response Cannot make further progress on this issue until the original reporter responds label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for customer response Cannot make further progress on this issue until the original reporter responds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moshOntong-IT @nank1ro