From 86afe8f8ce263cd15f115dfc710200479a7647c4 Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Mon, 20 Jun 2022 16:59:36 +0200 Subject: [PATCH] Puffin: Inline PuffinWriter.writeFully (#5088) --- .../main/java/org/apache/iceberg/puffin/PuffinWriter.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java b/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java index 1257c778f42a..6b4a1e9dd3c5 100644 --- a/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java +++ b/core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java @@ -78,7 +78,7 @@ public void add(Blob blob) { PuffinCompressionCodec codec = MoreObjects.firstNonNull(blob.requestedCompression(), defaultBlobCompression); ByteBuffer rawData = PuffinFormat.compress(codec, blob.blobData()); int length = rawData.remaining(); - writeFully(rawData); + IOUtil.writeFully(outputStream, rawData); writtenBlobsMetadata.add(new BlobMetadata(blob.type(), blob.inputFields(), fileOffset, length, codec.codecName(), blob.properties())); } catch (IOException e) { @@ -132,7 +132,7 @@ private void writeFooter() throws IOException { ByteBuffer footerPayload = PuffinFormat.compress(footerCompression, footerJson); outputStream.write(MAGIC); int footerPayloadLength = footerPayload.remaining(); - writeFully(footerPayload); + IOUtil.writeFully(outputStream, footerPayload); PuffinFormat.writeIntegerLittleEndian(outputStream, footerPayloadLength); writeFlags(); outputStream.write(MAGIC); @@ -150,10 +150,6 @@ private void writeFlags() throws IOException { } } - private void writeFully(ByteBuffer buffer) throws IOException { - IOUtil.writeFully(outputStream, buffer); - } - public long footerSize() { return footerSize.orElseThrow(() -> new IllegalStateException("Footer not written yet")); }