Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a configmap for the services that need quitting #14

Open
Reasonable-Solutions opened this issue Oct 24, 2023 · 1 comment
Open

Use a configmap for the services that need quitting #14

Reasonable-Solutions opened this issue Oct 24, 2023 · 1 comment

Comments

@Reasonable-Solutions
Copy link
Contributor

Reasonable-Solutions commented Oct 24, 2023 •
edited
Loading

It's silly that these are hardcoded and that the interface is rebuild and redeploy when we have the full k8s api at our fingertips, so to speak
@chinatsu
Copy link
Contributor

it is quite silly, but i chose that route since the services we support almost never change. granted, it sounds extra silly now that we recently got a PR requesting support for istio-proxy 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reasonable-Solutions @chinatsu