Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [Bexley][WW] Allow user to request new containers #5111

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

Please check the following:

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.

Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.

Thanks for contributing!

@nephila-nacrea nephila-nacrea self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (2460d7d) to head (6619f11).
Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 10.34% 26 Missing ⚠️
...rllib/FixMyStreet/App/Form/Waste/Request/Bexley.pm 40.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2460d7d) and HEAD (6619f11). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (2460d7d) HEAD (6619f11)
15 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5111       +/-   ##
===========================================
- Coverage   82.66%   69.99%   -12.68%     
===========================================
  Files         404      406        +2     
  Lines       31462    34407     +2945     
  Branches     4988     5825      +837     
===========================================
- Hits        26008    24083     -1925     
- Misses       3975     8762     +4787     
- Partials     1479     1562       +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant