Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FixaMinGata] Add various updates #5050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonkri
Copy link
Contributor

@jonkri jonkri commented Jul 7, 2024

Some minor FixaMinGata-related changes. The empty public_update.html file is intentional (we are currently not using this section of the inspect form).

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: [skip changelog]

Related to #4235.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (ce80472) to head (aedbdd2).

Files Patch % Lines
perllib/FixMyStreet/Cobrand/FixaMinGata.pm 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ce80472) and HEAD (aedbdd2). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (ce80472) HEAD (aedbdd2)
15 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5050       +/-   ##
===========================================
- Coverage   82.65%   69.18%   -13.47%     
===========================================
  Files         396      340       -56     
  Lines       30828    24586     -6242     
  Branches     4890     4649      -241     
===========================================
- Hits        25482    17011     -8471     
- Misses       3900     6224     +2324     
+ Partials     1446     1351       -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonkri jonkri force-pushed the fixamingata-various-updates branch 3 times, most recently from 836eb04 to 8f6e257 Compare July 8, 2024 12:04
@jonkri jonkri force-pushed the fixamingata-various-updates branch from 8f6e257 to 60a93de Compare July 8, 2024 14:01
@jonkri
Copy link
Contributor Author

jonkri commented Sep 25, 2024

Hi! Is there anything we can do to help move this along? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant