Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hylte] Add cobrand #5048

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jonkri
Copy link
Contributor

@jonkri jonkri commented Jul 7, 2024

Hylte kommun is a municipality in Sweden. Their cobrand is running on https://hylte.fixamingata.se/. The empty public_update.html file is intentional (we are currently not using this section of the inspect form).

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: [skip changelog]

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 15.90909% with 37 lines in your changes missing coverage. Please review.

Project coverage is 54.88%. Comparing base (ce80472) to head (151e66e).
Report is 181 commits behind head on master.

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Hylte.pm 17.94% 32 Missing ⚠️
perllib/FixMyStreet/Cobrand/FixaMinGata.pm 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ce80472) and HEAD (151e66e). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (ce80472) HEAD (151e66e)
15 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5048       +/-   ##
===========================================
- Coverage   82.65%   54.88%   -27.78%     
===========================================
  Files         396      343       -53     
  Lines       30828    25131     -5697     
  Branches     4890     4740      -150     
===========================================
- Hits        25482    13793    -11689     
- Misses       3900    10018     +6118     
+ Partials     1446     1320      -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonkri
Copy link
Contributor Author

jonkri commented Sep 25, 2024

Hi! Is there anything we can do to help move this along? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant