Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Camden] Setup Confirm integration #4999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Jun 10, 2024

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (1173010) to head (075bed2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Camden.pm 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4999   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files         404      404           
  Lines       31501    31513   +12     
  Branches     4993     4998    +5     
=======================================
+ Hits        26034    26045   +11     
+ Misses       3985     3984    -1     
- Partials     1482     1484    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorayMySoc MorayMySoc requested review from davea June 11, 2024 08:13
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To note, from discussion in Slack today, this doesn't work because Camden.pm has an open311_update_missing_data which is overriding the one from ConfirmOpen311. And open311_config can presumably be removed from Camden.pm.

MorayMySoc and others added 2 commits August 29, 2024 11:44
If a category change means the backend system has changed.
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed/squashed in your fixup commit, and then added a new commit on top, which I can't ask for review as it's your PR but if you could review it, thanks :)

@MorayMySoc
Copy link
Contributor Author

Thanks - changes look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants