-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Camden] Setup Confirm integration #4999
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4999 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 404 404
Lines 31501 31513 +12
Branches 4993 4998 +5
=======================================
+ Hits 26034 26045 +11
+ Misses 3985 3984 -1
- Partials 1482 1484 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To note, from discussion in Slack today, this doesn't work because Camden.pm has an open311_update_missing_data
which is overriding the one from ConfirmOpen311. And open311_config
can presumably be removed from Camden.pm.
bd8c480
to
a97a13f
Compare
a97a13f
to
e0f61c5
Compare
Adds necessary Confirm roles mysociety/societyworks#4298
If a category change means the backend system has changed.
e0f61c5
to
075bed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed/squashed in your fixup commit, and then added a new commit on top, which I can't ask for review as it's your PR but if you could review it, thanks :)
Thanks - changes look good to me! |
Adds necessary Confirm roles https://github.com/mysociety/societyworks/issues/4298
Fixes https://github.com/mysociety/societyworks/issues/4504
[skip changelog]