Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to run on node.js 0.12.x #8

Closed
mycoboco opened this issue Aug 23, 2015 · 2 comments
Closed

Fix to run on node.js 0.12.x #8

mycoboco opened this issue Aug 23, 2015 · 2 comments
Assignees
@mycoboco
Labels
bug

Comments

@mycoboco
Copy link
Owner

node.js 0.12.x contains v8's API incompatibility with <= 0.11.x:

https://strongloop.com/strongblog/node-js-v0-12-c-apis-breaking/

Need to fix related problems.
@mycoboco mycoboco added the bug label Aug 23, 2015
@mycoboco mycoboco self-assigned this Aug 23, 2015
@mycoboco
Copy link
Owner Author

Replacing the mdns module (#9) and applying a small fix to mp3-info seem to solve this issue.

@mycoboco
Copy link
Owner Author

An issue posted on mp3-info:

bendi/node-mp3info#3

mycoboco added a commit that referenced this issue Aug 30, 2015
@mycoboco
Fixed to run on node.js 0.12.x and to support mDNSResponder libraries (…
2e3711c 
…#8, #9):

- modified versions of node-mdns-js and node-mp3info are used for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mycoboco mycoboco

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mycoboco