Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name/nickname sync on registration step #80

Closed
11 tasks
Eldenroot opened this issue Jan 16, 2021 · 3 comments
Closed
11 tasks

Name/nickname sync on registration step #80

Eldenroot opened this issue Jan 16, 2021 · 3 comments
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@Eldenroot
Copy link
Member

Eldenroot commented Jan 16, 2021

As discussed here #55 the support for sync username instead of email should be added (if the gateway supports it):

  • Wordpress
  • Discord
  • Facebook
  • Google
  • Spotify
  • GitHub
  • LinkedIn
  • Yahoo
  • Yandex
  • Vkontakte - not support by Isango (check PR VKontakte Support #66 )
  • Microsoft

We will keep the list updated according to the actual support and added gateways in Isango.

Notes:

  • sync username only in registration step, not in other login
  • if more providers are linked to the account, we should sync only the first one, others will be skipped
@Eldenroot Eldenroot added the feature New feature or request label Jan 16, 2021
@effone
Copy link
Member

effone commented Jan 16, 2021

Isango is already syncing available username with the newly created account. If the username is not available then it tries to generate best possible / available username based on available data:
https://github.com/mybbgroup/Isango/blob/master/upload/inc/plugins/isango.php#L343

An option is already discussed to prompt the user to ender an username of his choice:
#19

So, is this issue still valid?

@Eldenroot
Copy link
Member Author

Maybe #19 is valid and could solve the issue with usernames... what do you think? Feel free to close this one.

@effone
Copy link
Member

effone commented Jan 16, 2021

Yes. 19 is valid and milestoned.
There is a comment in the plugin for a rare situation when no username is possible to be decided. We need user input in that scenario anyway.
https://github.com/mybbgroup/Isango/blob/master/upload/inc/plugins/isango.php#L356-L357

@effone effone added invalid This doesn't seem right wontfix This will not be worked on and removed feature New feature or request labels Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants