-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msg view: Add context menu #192
Comments
I've tried to use
|
I tried to use |
After doing that I get the error:
It's converting to ESM but the filepaths are being converted from ESM to commonJS e.g. Using The context menu applies to all windows, we would need to do some communications between the main and renderer processes to let it know which window to apply it. |
That's great! Can you please make a PR that updates to electron-vite 2.3.0 and electron 32.0.1, and fixes all issues that are caused by it? You'll need to find a different way to get the current directory, instead of __dirname.
|
#193 Updates the packages to output ESM and fixes any errors cause by it. |
|
Yes, I noticed the same. I tried to pass a webview DOM element, but that didn't work. I tried to re-use the electron-context-menu code, by using a lower level function, but it doesn't export any of the lower level functions. However, I did manage to attach a So, I think it makes sense to build the context menu ourselves, with our own menu. The menu can then be built using different UI components. The trigger would be the It appears the best approach is to fork the module, make the code more flexible. Only a function that accepts the |
DUP of #110 |
Reproduction:
Actual result:
Expected result:
The text was updated successfully, but these errors were encountered: