Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup measures show wrong rests when the Actual duration is modified #24976

Open
4 tasks done
cadiz2 opened this issue Sep 30, 2024 · 4 comments
Open
4 tasks done

Pickup measures show wrong rests when the Actual duration is modified #24976

cadiz2 opened this issue Sep 30, 2024 · 4 comments
Labels
regression MS4 Regression on a prior release UX/interaction

Comments

@cadiz2
Copy link

cadiz2 commented Sep 30, 2024

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

  1. New score for Flute, Time signature 4/4, with a pickup measure (1/4) created with the Wizard.
  2. Create two more incomplete measures (Actual duration : 1/4 and 1/8) in the following measures

Expected result: display of a quarter rest (as when creating the score) and a 8th rest

  • Works as expected with 4.3.2
  • Malfunctions as of version 4.4.0 (See GIF below)

Supporting files, videos and screenshots

Video pickup

What is the latest version of MuseScore Studio where this issue is present?

4.4.0

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Windows 10

Additional context

No response

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added regression MS4 Regression on a prior release UX/interaction labels Sep 30, 2024
@oktophonie
Copy link
Contributor

It it really a 'malfunction'? It seems just as likely that you might want a measure rest as you might want it to split into specific rests. After 'bar 0', bars with modified lengths are not likely to be pickup bars.

@cadiz2
Copy link
Author

cadiz2 commented Sep 30, 2024

This is a very unexpected result:

  1. Because I can't remember a previous version of MuseScore that didn't display the rest associated with the change in Actual Duration. And therefore confusing.
  2. In addition, why should the behavior be different when creating the score with the wizard and when changing it once it's been created? It's inconsistent, and therefore wrong in my eyes.

@cbjeukendrup
Copy link
Contributor

It looks like we'll need a way to let the user tell whether something is intended to be a pickup bar or not. Currently, some heuristic is used, but I doubt its validity. I believe this heuristic was changed in 4.4; that may or may not be related.

@MarcSabatella
Copy link
Contributor

For more history about the pickup heuristic, see issue #22080 and the PR that closed it, #22083. I'm not so sure the change in how rests are shown by default in empty measures was carefully considered and any change might be just an unintentional side effect. Assuming this is indeed the PR that changed the behavior, which seems likely, but I'm not by any means sure about that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression MS4 Regression on a prior release UX/interaction
Projects
None yet
Development

No branches or pull requests

5 participants