Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use all voices on this staff" voice assignment shouldn't enable reset button on single-staff instruments #23992

Open
4 tasks done
avvvvve opened this issue Aug 12, 2024 · 0 comments
Labels
P3 Priority: Low properties UI Visual issues affecting the UI (not notation)

Comments

@avvvvve
Copy link

avvvvve commented Aug 12, 2024

Issue type

UI bug (incorrect info or interface appearance)

Description with steps to reproduce

Dynamics/hairpins on single-staff instruments only have a single "All" option under the "Voice assignment" property, whereas on grand staff instruments there are two options ("All voices on instrument" and "All voices on this staff").

In the backend, "All" on a single staff instrument is the same as "All voices on instrument" on a grand staff instrument, and this is the default setting of the property.

So if you copy a dynamic from a grand staff instrument set to "All voices on this staff" to a single-staff instrument, in properties "All" is still selected but the Reset button is turned on because technically it's still not the default. You can also trigger this state using the "Use all voices on this instrument" shortcut (Ctrl + Alt + - OR Cmd + Opt + -).

The reset button should not be enabled in this case on the single-staff instrument, because to the user, there's only one "All" option and nothing is actually getting reset.

It should work something like this:

  • The dynamic is set to "All voices on instrument" (or "All" on a single-staff instrument)
    • Reset button is disabled
  • The dynamic is set to "All voices on this staff"
    • Is the instrument a single-staff instrument?
      • YES: Reset button is disabled
      • NO: Reset button is enabled (i.e. it's on an instrument with more than one staff)

Elements affected:

  • Dynamics
  • Hairpin: Crescendo hairpin
  • Hairpin: Crescendo line
  • Hairpin: Decrescendo hairpin
  • Hairpin: Decrescendo line

Supporting files, videos and screenshots

all_staff_reset.mov

What is the latest version of MuseScore Studio where this issue is present?

Nightly Aug 12

Regression

No.

Operating system

macOS 14.5

Additional context

No response

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Aug 12, 2024
@avvvvve avvvvve added P2 Priority: Medium properties labels Aug 12, 2024
@bkunda bkunda added P3 Priority: Low and removed P2 Priority: Medium labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low properties UI Visual issues affecting the UI (not notation)
Projects
Status: Some release after that
Development

No branches or pull requests

4 participants