Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter roadmap #4

Open
Remi-Gau opened this issue Jun 12, 2023 · 5 comments
Open

Converter roadmap #4

Remi-Gau opened this issue Jun 12, 2023 · 5 comments

Comments

@Remi-Gau
Copy link
Collaborator

  • input format: aim first for the eyetracker that occupy the biggest share of the market
    • eyelink
    • tobii
  • allow conversion from from BIDS "legacy" format _recording-eyetracking_physio.tsv.gz
  • usable as a library and as a bidscoin plugin
  • use opensource datasets as test input files
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jul 12, 2023

  • build container for converter : start from bidsphysio and adapt it
  • test pyedfread: https://github.com/nwilming/pyedfread
    • see what it does: inputs, outputs...
  • from EDF --> tsv + json broken down in:
    • from EDF --> ascii --> tsv
    • from EDF --> ascii --> json

@julia-pfarr
Copy link
Collaborator

julia-pfarr commented Jul 13, 2023

Output of bidsphysio:

  • from EDF --> tsv + json broken down in:

    • from EDF --> ascii --> tsv
"Columns": [
    "samples",
    "gx_left",
    "gy_left",
    "pa_left",
    "fixation",
    "saccade",
    "blink"
],

Comparison BEP020 to output bidsphysio:

  • from EDF --> ascii --> json
"Columns": [
    "samples",
    "gx_left",
    "gy_left",
    "pa_left",
    "fixation",
    "saccade",
    "blink"
],
"RecordedEye": "Left",
"SamplingFrequency": 1000,
"StartTime": 0.0

Missing in json by bidsphysio:

@julia-pfarr
Copy link
Collaborator

Differentiation pyedfread and bidsphysio: pyedfread only makes edf files readable, bidsphysio code decides what to extract from it for bids

@Remi-Gau
Copy link
Collaborator Author

Makes me realize that we got eye1 and eye2 but we do not specify how to know which eye is the right one and which one is the left when both are recorded.

@Remi-Gau
Copy link
Collaborator Author

Another thought.
Given that bidsphysio gives the typical output for what will be the typical "legacy" eyetracking format (the one that is recommended in the spec at the moment), the things you did highlighted @julia-pfarr will help us flag missing metadata to the user when converting from legacy to BEP20 valid output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants