Make VirtualMatrixPanel::getCoords() public. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good suggestion, I have merged. |
toine512
added a commit
to toine512/ESP32-HUB75-MatrixPanel-DMA
that referenced
this pull request
Apr 29, 2024
commit b67bd96 Merge: 1e4b46e 625fe45 Author: mrcodetastic <[email protected]> Date: Mon Apr 22 20:05:34 2024 +0100 Merge pull request mrcodetastic#621 from board707/virtual_getCoords Make VirtualMatrixPanel::getCoords() public. commit 625fe45 Author: board707 <[email protected]> Date: Sat Apr 20 22:26:16 2024 +0300 Make VirtualMatrixPanel::getCoords() public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making VirtualMatrixPanel::getCoords() public will allow users to inherit VirtualMatrixPanel class and create their own variants of the getCoords() function for complex quarter scan panel cases.
If PR merged, I will write an example of creating and using a virtual getCoords() function.