Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignette typos from AFIDEP work #420

Open
3 tasks
jeffeaton opened this issue Jan 4, 2024 · 0 comments
Open
3 tasks

vignette typos from AFIDEP work #420

jeffeaton opened this issue Jan 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jeffeaton
Copy link
Collaborator

jeffeaton commented Jan 4, 2024

Some typos and out-of-date elements in example vignette from review with AFIDEP (thanks @mcewenkhundi):

  • second appearance of artnum_quarter_id_t1 should be _t2

    #' * `artnum_quarter_id_t1` and `artnum_quarter_id_t1` are the time point at

  • Referring to ANC quarter IDs is out of date. These are now provided as full year data.

    #' * `anc_quarter_id_t1` and `anc_quarter_id_t2` are typically a range of 3-4 quarters. Data will be aggregated over these quarters for a larger sample size. They
    #' will typically be consecutive quarters, though a quarter could be dropped for
    #' example if there were reporting problems known to affect a given quarter.

  • Plot does not select the calendar_quarter, so it is probably overplotting all quarters

    #' 15-49 prevalence by district
    ##+ prev_by_district_15, fig.height = 4, fig.width = 7
    indicators %>%
    filter(age_group == "Y015_049",
    indicator == "prevalence",
    area_level == 4) %>%
    ggplot(aes(fill = mode)) +
    geom_sf() +
    viridis::scale_fill_viridis(labels = scales::percent_format()) +
    th_map() +
    facet_wrap(~sex)

@jeffeaton jeffeaton added the bug Something isn't working label Jan 4, 2024
@jeffeaton jeffeaton self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant