Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkIdentifier is missing in generated Model Design for DI model #629

Open
mpostol opened this issue Aug 15, 2021 · 2 comments
Open

NetworkIdentifier is missing in generated Model Design for DI model #629

mpostol opened this issue Aug 15, 2021 · 2 comments
Assignees
Labels
Bug Bug in the code.

Comments

@mpostol
Copy link
Owner

mpostol commented Aug 15, 2021

Copy of the mpostol/UA-Nodeset#51

@mpostol
Copy link
Owner Author

mpostol commented Mar 9, 2022

The commit 3ec08b8 causes unhandled exception in many models including but not limited to DI

mpostol added a commit that referenced this issue Mar 9, 2022
mpostol added a commit that referenced this issue Mar 9, 2022


- removed exception thrown while unsupported reference is encountered
mpostol added a commit that referenced this issue Mar 12, 2022


- fixed AddressSpaceContextImportUANodeSetNull UT
mpostol added a commit that referenced this issue Mar 12, 2022


- improved CalculateNodeReferencesNullUANodeTest
mpostol added a commit that referenced this issue Mar 13, 2022


- improved UT to investigate the problem
- improved code to figure how to fix this problem
= UT 👍
@mpostol
Copy link
Owner Author

mpostol commented Mar 16, 2022

Problems to fix:

  • new nodes added in the second circle are duplicated
  • StateNumber variable is not generated and no warning added to the log
  • Some references have the wrong target (circular references); DeviceSet should point to DeviceFeatures in case IsInverse="true"
  • the model contains 0 nodes and no errors/warnings reported

mpostol added a commit that referenced this issue Mar 16, 2022
mpostol added a commit that referenced this issue Mar 16, 2022


- the model contains 0 nodes and no errors/warnings reported
mpostol added a commit that referenced this issue Mar 17, 2022


- fixes #651
- UT must be fixed - nodes could be duplicated if they are the target of 2+ references
mpostol added a commit that referenced this issue Mar 19, 2022


- Development in progress - refactoring code to prepare it for future changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in the code.
Projects
None yet
Development

No branches or pull requests

1 participant