Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi distfile: test problems #95

Open
0-wiz-0 opened this issue Jun 11, 2023 · 0 comments
Open

pypi distfile: test problems #95

0-wiz-0 opened this issue Jun 11, 2023 · 0 comments

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jun 11, 2023

When running the self tests using the pypi source distfile, many fail because of three missing files:

fxa/tests/bad-key.json
fxa/tests/jwks.json
fxa/tests/private-key.json

Please include them in the distfile.

Also, many more fail because the test server returns 502, for example:

_________________________________________________________________________________ TestCoreClient.test_account_creation _________________________________________________________________________________
                                                                                                                                                                                                        
self = <fxa.tests.test_core.TestCoreClient testMethod=test_account_creation>                                                                                                                            
                                                                                                                                                                                                        
    def test_account_creation(self):                                                                                                                                                                    
        acct = TestEmailAccount()                                                                                                                                                                       
        acct.password = DUMMY_PASSWORD                                                                                                                                                                  
>       session = self.client.create_account(acct.email, DUMMY_PASSWORD)                                                                                                                                
                                                                                                                                                                                                        
fxa/tests/test_core.py:58:                                                                                                                                                                              
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
fxa/core.py:64: in create_account                                                                                                                                                                       
    resp = self.apiclient.post(url, body)                                                                                                                                                               
fxa/_utils.py:338: in post                                                                                                                                                                              
    return self.request("POST", url, json, **kwds)                                                                                                                                                      
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                                                                                                                                                                                                        
self = <fxa._utils.APIClient object at 0x761ebf01cc20>, method = 'POST', url = 'https://stable.dev.lcip.org/auth/v1/account/create'                                                                     
json = {'authPW': '567643e5ada89e9fc87f1f3b4e8d75a7c6faaa7d7695967c924588a8224b2396', 'email': '[email protected]'}, retry_auth_errors = True                                                
kwds = {'headers': {'User-Agent': 'Mozilla/5.0 (Mobile; Firefox Accounts; rv:1.0) PyFxA/0.7.7 python-requests/2.31.0'}, 'timeout': 30}, resp = <Response [502]>                                         
headers = {'User-Agent': 'Mozilla/5.0 (Mobile; Firefox Accounts; rv:1.0) PyFxA/0.7.7 python-requests/2.31.0'}, content_type = 'text/html', msg = 'API responded with non-json content-type: {0}'        
...
        # Everything should return a valid JSON response.  Even errors.                                                                                                                                 
        content_type = resp.headers.get("content-type", "")                                                                                                                                             
        if not content_type.startswith("application/json"):                                                                                                                                             
            msg = "API responded with non-json content-type: {0}"                                                                                                                                       
>           raise fxa.errors.OutOfProtocolError(msg.format(content_type))                                                                                                                               
E           fxa.errors.OutOfProtocolError: API responded with non-json content-type: text/html                                                                                                          
                                                                                                                                                                                                        
fxa/_utils.py:270: OutOfProtocolError                                                                                                                                                                   

No idea how to fix that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant