Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock server responses for core API tests #4

Open
rfk opened this issue Dec 30, 2014 · 3 comments
Open

Mock server responses for core API tests #4

rfk opened this issue Dec 30, 2014 · 3 comments

Comments

@rfk
Copy link
Contributor

rfk commented Dec 30, 2014

The tests currently talk to a live server, which is great for dev testing but not ideal for an automated suite. We should change them to use mocked responses by default, but still be able to talk to a live server if requested explicitly.

@vladikoff
Copy link

We have these mocks for the fxa-js-client that might be useful: https://github.com/mozilla/fxa-js-client/tree/master/tests/mocks

@leplatrem
Copy link
Contributor

It might result quite complex to write a single piece of code that would fit with both mocked and real server responses.

But I guess having two test suits could make sense! One with mocked server responses focused on unit tests, and another one talking to a real server focused on functional tests.

(my two cents)

@Natim
Copy link
Collaborator

Natim commented Jul 23, 2015

I started using mocks for #23 and #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants