Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perception tutorial missing some updates merged in (moveit1's) moveit_tutorials #708

Open
130s opened this issue Jun 20, 2023 · 4 comments
Assignees

Comments

@130s
Copy link
Contributor

130s commented Jun 20, 2023

Description

Overview of your issue here.

For perception tutorial, I manually confirmed that the changes in these PRs are not included in moveit2_tutorials.

Expected behaviour

@130s 130s mentioned this issue Jun 20, 2023
4 tasks
130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 22, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 22, 2023
@130s
Copy link
Contributor Author

130s commented Jun 22, 2023

In #700 I manually cherry-picked the changes from the PRs listed in #708.

  • Changes from each PR is committed separately for the better visibility.
  • Initially I tried to git cherry-pick those changes, but some PRs included changes outside of perception tutorial, which is not my scope of the PR, so I gave up and went ahead manually applying changes.

130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 28, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 28, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 28, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this issue Jun 28, 2023
@130s 130s self-assigned this Jun 29, 2023
@130s
Copy link
Contributor Author

130s commented Jun 29, 2023

Resolution to this is now ready for review in #700

130s added a commit to 130s/moveit2_tutorials that referenced this issue Sep 27, 2023
130s added a commit to 130s/moveit2_tutorials that referenced this issue Sep 27, 2023
@130s

This comment was marked as off-topic.

@130s 130s closed this as completed Aug 20, 2024
@130s
Copy link
Contributor Author

130s commented Aug 20, 2024

Sorry I closed a wrong ticket. Reopening.

@130s 130s reopened this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant