Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckStartStateBounds does not support REVOLUTE and NOT Continuous type joints #2924

Open
chama1176 opened this issue Jul 22, 2024 · 1 comment
Labels
bug Something isn't working stale Inactive issues and PRs are marked as stale and may be closed automatically.

Comments

@chama1176
Copy link

Description

CheckStartStateBounds does not support REVOLUTE and NOT Continuous type joints

Your environment

  • ROS Distro: Jazzy
  • OS Version: e.g. Ubuntu 24.04
  • Binary build 2.10.0

Steps to reproduce

  • Set the initial posture of the actual robot to a position beyond the urdf limit.
  • Press “plan” button in rviz to plan the trajectory.

Expected behaviour

CheckStartStateBounds is not SUCCESS. And fixed to joint limit in case fix_start_state is true.

Actual behaviour

CheckStartStateBounds is SUCCESS.

Details

In #2429, CheckStartStateBounds is refactored.
The logic has also been changed so that the check is skipped for non-infinite rotation joints, which are used in most arm joints.

switch (jmodel->getType())
{
case moveit::core::JointModel::REVOLUTE:
{
if (static_cast<const moveit::core::RevoluteJointModel*>(jmodel)->isContinuous())
{
double initial = start_state.getJointPositions(jmodel)[0];
start_state.enforceBounds(jmodel);
double after = start_state.getJointPositions(jmodel)[0];
if (fabs(initial - after) > std::numeric_limits<double>::epsilon())
{
changed_req = true;
}
}
break;
}

@chama1176 chama1176 added the bug Something isn't working label Jul 22, 2024
Copy link

github-actions bot commented Sep 5, 2024

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant