Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More named colour fixes #37

Open
niuserre opened this issue Jan 8, 2023 · 3 comments
Open

More named colour fixes #37

niuserre opened this issue Jan 8, 2023 · 3 comments

Comments

@niuserre
Copy link

niuserre commented Jan 8, 2023

Loving the mod, I know you said it's for other modules to use but all I really want to do was improve my colours and it's wonderful for that. Not totally sure how this works so no worries if this is just me trying to do awkward combinations.

Nothing seems to change this scrollbar colour (with or without Colorise ticked):
image
CSS via dev tools says Pseudo ::scrollbar-thumb element and points to style.css:474 which is:

::-webkit-scrollbar-thumb {
  outline: none;
  border-radius: 3px;
  background: #782e22;
  border: 1px solid var(--color-border-highlight);
}
:root {
  scrollbar-width: thin;
  scrollbar-color: #782e22 #111;
}

And this one only happens using the Colorise options specifically, the search in the sidebar gets dark on dark:
image

Which is related to foundry-vtt-colors.css:196 and foundry-vtt-colors.css:21:

.directory .directory-header .header-search input {
    background: rgba(0, 0, 0, 0.05);

input[type="text"], input[type="number"], input[type="password"], input[type="date"], input[type="time"], input[type="search"], input[type="color"], input[type="color"][data-edit], select {
    ~~background: rgba(0, 0, 0, 0.05);~~
    border-color: var(--app-dialog-background-shaded);
    color: var(--app-dialog-background-contrast);
}

I have used the custom CSS module to do .header-search input {color:#ffffff;} which is good enough for me.

@KelSolaar
Copy link

KelSolaar commented Jan 10, 2023

This worked for me:

image

@mouse0270
Copy link
Owner

Yeah, the colorized options was just kinda me quickly showing how to use the themer. I am happy to patch stuff like this though, because this should be updated on libThemer

@niuserre
Copy link
Author

Yeah, the colorized options was just kinda me quickly showing how to use the themer. I am happy to patch stuff like this though, because this should be updated on libThemer

The colorising is awesome and I don't expect perfection. I'm happy to mention things I notice so you can choose what to do with the feedback 💜

image

I believe that's just changing the outline. In my screenshot you can see the border is turquoise but the middle is brown. Bit hard to see but I think this screenshot still has the middle as brown, just with a red outline. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants