-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusted Players are not affected by GM Theme option #35
Comments
gonna use this thread to say that my GM theme option, actually, does not enable the theme for any user at all, I wonder if I'm doing something wrong or it's just a bug |
Is there any errors in the console? If your player is logged in does it change the setting when you change a setting? I made a change in the last update that I only pass in the most recent update and not all of them. However it should sync when they login to the current theme. Can you send me a photo of your settings for libThemer |
Alright, so it looks like the variable array that should be storing the theme isn't an array and is causing the |
No no, I guess it's a bug from another module, a refresh solves it, so it's fine |
So this array breaking is something I would need to solve on my end? |
Its a bug, I am not sure what caused it, I think I have an idea how to fix it but I want to test it before I just tell you to make sure I don't break more things. |
Just wanted to mention that it is working for me on both a Player and a Trusted Player. After checking 'Enable GM Theme' I had to relog both the GM and the player to get it to work (initially I just did the player but that wasn't enough), but it does work as expected. I am not using the custom theme directory, I just used the Manage Presets thing. Here is my module list of things that are working fine with it in case it's a conflict (DnD5e system). |
I just realized that users with the trusted player level of permission are not affected by the GM Theme option. Well, from what I saw they are, but not in all aspects, so the UI looks very strange and unreadable.
Maybe an option to enable the GM theme just for certain roles could enhance that?
The text was updated successfully, but these errors were encountered: