Add scrobble_filter to provide a configurable list of URI schemes not… #29
Conversation
|
The failure appears to be something in pylast that I haven't changed, so I don't know what's failing. It runs on my system. |
README.rst
Outdated
| @@ -41,12 +41,14 @@ found at ``~/.config/mopidy/mopidy.conf``:: | |||
| [scrobbler] | |||
| username = alice | |||
| password = secret | |||
| scrobble_filer = list | |||
|
Looks good. I think I would call it "blacklist" though, to make it clearer that those extensions won't be scrobbled. It also means that you can add a "whitelist" at some point too. Maybe |
|
I agree. backend_blacklist is better. It's still failing the checks though but I don't know why. It's running fine for me. |
| @@ -41,12 +41,14 @@ found at ``~/.config/mopidy/mopidy.conf``:: | |||
| [scrobbler] | |||
| username = alice | |||
| password = secret | |||
| backend_blacklist = list | |||
There was a problem hiding this comment.
I think it's worth considering a word other than "blacklist". How about "ignorelist"?
There was a problem hiding this comment.
Agree.
We also have some "ignore"/"exclude" lists in the config of other extensions, like Mopidy-Local and Mopidy-Files. I'd like this to be aligned with the naming there.
| @@ -2,3 +2,4 @@ | |||
| enabled = true | |||
| username = | |||
| password = | |||
| backend_blacklist = | |||
There was a problem hiding this comment.
Looks like you're missing a newline at the end of the file here.
… not scrobble
This should fix #28, however I've been testing it today and found that even with the Spotify web app scrobbling enabled, I don't see double scrobbles from Mopidy even if mopidy is also scrobbling.
Not sure why this is, perhaps it's only temporary, but adding this as a config value dosn't do any harm.