Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying from Mobile devices the editor is partially hidden. #36

Open
aspark21 opened this issue Oct 7, 2014 · 2 comments
Open

Replying from Mobile devices the editor is partially hidden. #36

aspark21 opened this issue Oct 7, 2014 · 2 comments

Comments

@aspark21
Copy link
Contributor

aspark21 commented Oct 7, 2014

Moodle 2.7.2 build 20141002 / ForumNG version: latest master
Theme based on clean / bootstrapbase

The editing box is partially hidden when replying to a forumNG post inline from an iOS or Android device.

This all seems to be based on the user-agent as desktop browser versions with a desktop UA displays correctly, whereas desktop browser versions with a Mobile UA get the issue. See attached screenshots.

desktop safari with iphone user agent
desktop-safari-with-iphone-user-agent

desktop safari
desktop-safari

Can this be fixed in the plugin or does it need to be fixed in the renderers of Moodle core?

@jason-platts
Copy link
Member

Phone size devices or tablets?

I think the main issue here is that because we don't run a bootstrap theme there are probably going to be problems when viewing in small windows or on small devices, especially as there are some javascript hacks implemented to make forumng work on mobile OS in the old themes.

I'll have a look, there may be something that you can put in your theme to fix it or it may be more terminal!

Unfortunately we don't have any schedule for moving to bootstrap, so this type of problem is going to keep cropping up until we do.

@aspark21
Copy link
Contributor Author

aspark21 commented Oct 7, 2014

Hi Jason,

Screenshots are for phone size in portrait mode, seems to be ok in landscape.

Seems ok on the iPad in portrait size so I'm guessing most tablets (maybe not the phablets) should be ok.

Figured we might have to fix it in our themes for the time being but it also occurred in clean which is the new default with Moodle HQ having removed all other themes from core. So most using this plugin will likely be affected as most institutions are making / have already made the switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants