Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling always throws NotImplemented #112

Open
praeclarum opened this issue Mar 29, 2017 · 1 comment
Open

Error handling always throws NotImplemented #112

praeclarum opened this issue Mar 29, 2017 · 1 comment

Comments

@praeclarum
Copy link

On this line: https://github.com/mono/debugger-libs/blob/master/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L1547

The code always throws NotImplementedException even if there is an error handler.

Should the throw be in an else?
@vargaz
Copy link
Contributor

vargaz commented Mar 30, 2017

I think the error handler should not return, but throw some kind of exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vargaz @praeclarum