PYTHON-4781 Handle errors on Async PyMongo import #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Sep 20, 2024
pymongo/__init__.py
Outdated
| # PYTHON-4781: Importing asyncio can fail on Windows. | ||
| import warnings | ||
|
|
||
| warnings.warn(f"Failed to import Async PyMongo: {e}", RuntimeWarning, stacklevel=2) |
There was a problem hiding this comment.
- Should we use ImportWarning instead?
ImportWarning: Base category for warnings triggered during the process of importing a module (ignored by default).
-
Suggest
{e!r}to provide the repr which will include the exception class instead of just the message. -
Suggest
import warnings as _warningsto avoid polluting the pymongo namespace.
ShaneHarvey
approved these changes
Sep 20, 2024
|
Will this cause type errors now that AsyncMongoClient is not always defined? |
Perhaps on a system where importing asyncio is broken, but that system would have more concerning problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.