Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On --squirrel-updated event, don't recreate shortcut if not already there #9

Open
romaincointepas opened this issue Jul 23, 2016 · 4 comments
Assignees

Comments

@romaincointepas
Copy link

If the user has deleted the desktop shortcut, at the moment it's recreating it every time the app updates.

atom/atom checks if the desktop shortcut is there on --squirrel-updated, and if not (meaning it has been deleted), don't recreate it (actually, they recreate it then delete it).

See https://github.com/atom/atom/blob/master/src/main-process/squirrel-update.coffee#L100-L106

Would it make sense to implement this logic by default?

@imlucas imlucas self-assigned this Jul 23, 2016
@imlucas
Copy link
Contributor

imlucas commented Jul 26, 2016

@romaincointepas Sounds good to me! Would you be interested in submitting a PR for this?

@ccnokes
Copy link

ccnokes commented Jun 6, 2017

I might have some time within the next few weeks to PR this if there's still interest in it 😸.

ccnokes added a commit to ccnokes/electron-squirrel-startup that referenced this issue Jun 13, 2017
@gschier
Copy link

gschier commented Nov 17, 2017

I would love this as well. How's that fork coming @ccnokes?

@ccnokes
Copy link

ccnokes commented Nov 17, 2017

@gschier hmmm..... I can't remember 😸 . I think that fork is probably good to go, it just needs to be tested, and then PR it. I probably won't have time to revisit this till next year though 😢 . Feel free to fork my fork or copy and paste into your own fork (assuming it works) or whatever though 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants