New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit button should be disabled instead of non existent when viewing a pr with merge conflicts #72

Open

mdavoodi opened this issue May 16, 2017 · 0 comments

Labels

Contributor

mdavoodi commented May 16, 2017

I got the following feedback from a user:

If the pull request you’re viewing has a merge conflict and you’re showing “All changes in this pull request”, the “edit” icon to the left of “blame” doesn’t show.

We should add a disabled edit button with a caption saying they need to resolve conflicts before they can edit.

mdavoodi added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment