Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Make InlineFixedVector work on CollectionElement #3478

Open
JoeLoser opened this issue Sep 13, 2024 · 3 comments
Open

[stdlib] Make InlineFixedVector work on CollectionElement #3478

JoeLoser opened this issue Sep 13, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JoeLoser
Copy link
Collaborator

As mentioned at #3445 (comment), we can make InlineFixedVector work on memory-only types such as CollectionElement. In the latest nightly tonight, InlineArray and Span have been relaxed to work on CollectionElement instead of CollectionElementNew, which should unblock this work.
@JoeLoser JoeLoser added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 13, 2024 — with Linear
@gabrieldemarmiesse
Copy link
Contributor

gabrieldemarmiesse commented Sep 14, 2024 •
edited
Loading

Isn't InlinedFixedVector deprecated? I know the behavior is slightly different from small buffer optimization, at least the one I implemented, but I'm not sure this behavior will be needed a lot once #2825 lands.

@JoeLoser
Copy link
Collaborator Author

Isn't InlinedFixedVector deprecated? I know the behavior is slightly different from small buffer optimization, at least the one I implemented, but I'm not sure this behavior will be needed a lot once #2825 lands.

Yeah, but it's unclear how long it will be before we can land SBO, that's all.

@gabrieldemarmiesse
Copy link
Contributor

Fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoeLoser @gabrieldemarmiesse