File too Big (Upload Issue) #1559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modoboa/modoboa-webmail#170 size2 integer was returning 0 when called with int values.
returns correct values now
works now.
|
first commit in python. please give me a hint where to edit unit-test, or what to make better next time. |
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 143 143
Lines 7441 7441
=======================================
Hits 6395 6395
Misses 1046 1046 |
|
@makakken Thank you. You can find examples in the modoboa/lib/tests folder. |
|
PR #1595 fixes this issue and adds unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
issue 170 in modoboa-webmail modoboa/modoboa-webmail#170
Current behavior before PR:
returns 0 if you enter int values (or add "b" for bytes)
Desired behavior after PR is merged:
returns right int if feeded with int (should we add "b" for bytes as well?)