-
|
As the positions ot the project leader and project deputy of this MAP-LIB are vacant at the moment, I wonder who is in charge to merge the pull requests which passed all the checks. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 3 replies
-
|
AFAIK every library officer, but you have to wait for the automatic tests and the approvals. |
Beta Was this translation helpful? Give feedback.
-
|
In my ideal world, the assignee of the PR merges the changes. Every member of MAP-Lib can do so. Would be also ideal, if the open reviewers are unassigned. |
Beta Was this translation helpful? Give feedback.
-
|
A question remains who shall be the assignee? |
Beta Was this translation helpful? Give feedback.
-
|
That is the freedom of the PR author. There is no strict process here. |
Beta Was this translation helpful? Give feedback.
-
|
Do you mean "reviewes"? |
Beta Was this translation helpful? Give feedback.
-
|
No, I usually remove the reviewers who did not review from merged PRs.
|
Beta Was this translation helpful? Give feedback.
-
|
Ok, having open reviewers after merging PR makes no sense. |
Beta Was this translation helpful? Give feedback.
In my ideal world, the assignee of the PR merges the changes. Every member of MAP-Lib can do so. Would be also ideal, if the open reviewers are unassigned.