Use the Spanish name of Amazonas, Peru #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of the Quecha version. See https://en.wikipedia.org/wiki/ISO_3166-2:PE
There was a problem hiding this comment.
So this works for me but I had to perform a few other steps to get it working which resulted in some additional changes that might be required for this PR to have an effect.
Steps
- Take your change to data.csv
- Delete
iso3166.min.js - Since I use python 3 I needed to update parse.py to meet python 3 syntax.
- Run
make. This generated theiso3166.min.jsfile. I'm not sure if this file is required or not for your change to take effect when published in a package repository such as npm.
You can see all of my changes here: https://github.com/mitodl/iso-3166-2.js/tree/collin-test
|
I forgot about making the minified version. Can you open a separate PR for your python3 changes? It seems like we should add those (first), but not in the same PR/commit. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user from Peru wrote in and pointed out that Amazonas is missing from our list of regions in Peru.
After consulting with Wikipedia, I found that we are using the Spanish spelling of Peru regions, except for Amazonas, where we use the Quecha spelling. I prefer consistency to trying to figure out a domestic political issue. We should change Amarumayu to Amazonas.
What are the relevant tickets?
mitodl/micromasters#5247
What's this PR do?
Amarumayu->AmazonasHow should this be manually tested?
install the library in an instance of micromasters and edit your profile to change your address to Peru.
Related issues
If you give this a thumbs up, please open an upstream PR with the original library. It doesn't seem to be actively maintained, buy I'd still like to share our fixes.