Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete namespace cli command #424

Merged
merged 14 commits into from
Jul 10, 2023
Merged

Delete namespace cli command #424

merged 14 commits into from
Jul 10, 2023

Conversation

poornima-krishnasamy
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 16.66% and project coverage change: -1.25 ⚠️

Comparison is base (ac44dde) 38.60% compared to head (86462aa) 37.36%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   38.60%   37.36%   -1.25%     
==========================================
  Files          49       49              
  Lines        2961     3129     +168     
==========================================
+ Hits         1143     1169      +26     
- Misses       1697     1832     +135     
- Partials      121      128       +7
Impacted Files Coverage Δ
pkg/environment/applier.go 0.00% <0.00%> (ø)
pkg/environment/environmentApply.go 15.53% <18.32%> (+0.53%) ⬆️
pkg/util/util.go 64.80% <47.05%> (-2.80%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@poornima-krishnasamy poornima-krishnasamy marked this pull request as ready for review July 5, 2023 15:29
jaskaransarkaria
jaskaransarkaria reviewed Jul 10, 2023
View reviewed changes
pkg/commands/environment.go Show resolved Hide resolved
pkg/environment/environmentApply.go Outdated Show resolved Hide resolved
pkg/environment/environmentApply.go Outdated Show resolved Hide resolved
pkg/environment/environmentApply.go Outdated Show resolved Hide resolved
jaskaransarkaria
jaskaransarkaria approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@jaskaransarkaria jaskaransarkaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poornima-krishnasamy poornima-krishnasamy merged commit 2501016 into main Jul 10, 2023
7 checks passed
@poornima-krishnasamy poornima-krishnasamy deleted the delete-namespace branch July 10, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskaransarkaria jaskaransarkaria jaskaransarkaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poornima-krishnasamy @codecov-commenter @jaskaransarkaria