Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Whole Image" does not work when previewing an image #229019

Open
zheung opened this issue Sep 19, 2024 · 1 comment · May be fixed by #229082
Open

"Whole Image" does not work when previewing an image #229019

zheung opened this issue Sep 19, 2024 · 1 comment · May be fixed by #229082
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@zheung
Copy link

zheung commented Sep 19, 2024

Type: Bug

I found this when comparing images in git repositories. The problem also occurs when opening an image directly.
Normally it should show the whole image by default.

"Whole Image" not works on Insider 1.94:
20240919142750

It works on Current 1.93 (I checked it in sandbox):
20240919142814

It works on Web too:
20240919142857

I had simply modified this file to temporarily restore the display of the whole image. So the problem could be in this file or nearby:
${codepath}/resources/app/extensions/media-preview/media/imagePreview.css
imagePreview.css

VS Code version: Code - Insiders 1.94.0-insider (4f485cf, 2024-09-18T09:24:10.356Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs AMD Ryzen 7 5800X 8-Core Processor (16 x 4500)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 63.92GB (48.05GB free)
Process Argv --crash-reporter-id 43ab0d18-95d1-486b-8eba-b11ee7cec582 --crash-reporter-id 43ab0d18-95d1-486b-8eba-b11ee7cec582
Screen Reader no
VM 0%
A/B Experiments 
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
9c06g630:31013171
a69g1124:31018687
dvdeprecation:31040973
dwnewjupyter:31046869
nb_pkg_only:31057982
nativerepl1:31134653
refactort:31084545
pythonrstrctxt:31093868
flighttreat:31119334
wkspc-onlycs-t:31132770
nativeloc1:31118317
wkspc-ranged-c:31125598
cf971741:31111988
jh802675:31132134
e80f6927:31120813
fje88620:31121564
12bdf347:31141542
iacca1:31138162
notype1:31136707
c9j82188:31138334
f8igb616:31140137
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 19, 2024

Thanks for the detailed report

Caused by 945d4cd

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 19, 2024
@mjbvz mjbvz mentioned this issue Sep 19, 2024
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 19, 2024
@mjbvz
Revert "Use separate div for image preview transparency grid"
94a8e4a 
This reverts commit 945d4cd.

Fixes microsoft#229019
@mjbvz mjbvz linked a pull request Sep 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Use separate div for image preview transparency grid" mjbvz/vscode
2 participants
@zheung @mjbvz