Edit Context: Screen Reader Users Feedback

[aiday-mar]

Pinging @jooyoungseo, @rperez030 and @meganrogge

Recently we have been working on adopting the EditContext API (https://developer.mozilla.org/en-US/docs/Web/API/EditContext_API) within VS Code. The EditContext is a new DOM property that can be set on DOM elements which decouples text input from the textual mutations of the DOM element. Essentially when the user focuses a DOM element on which an EditContext is set and types, the EditContext fires 'textupdate' events, and it is up to the user to mutate the DOM element with the changes from this event.

There are several reasons why we have adopted this API:

• This API has allowed us to greatly simplify the code which handles text input events.
• This API has allowed us to close numerous IME related bugs
• This API can allow us to emit customized typing information from the input events

We have an experimental setting which enables the EditContext API with ID editor.experimentalEditContextEnabled. We would like to ask @jooyoungseo and @rperez030 if when you have time you could try the setting with a screen reader and let us know if you see any issues on typing in the various inputs of VS Code (could be the editor, the panel chat input, the SCM view, the quick input, ie any input that accepts text insertions). We would like to gather feedback from screen reader users before enabling this setting by default.

[rperez030]

Thanks for the heads-up. I'll give it a try and report back here. From: Aiday Marlen Kyzy ***@***.***> Sent: Thursday, September 19, 2024 6:55 AM To: microsoft/vscode ***@***.***> Cc: Mention ***@***.***> Subject: [microsoft/vscode] Edit Context: Screen Reader Users Feedback (Issue #229051) Pinging @jooyoungseo<https://github.com/jooyoungseo>, @rperez030<https://github.com/rperez030> and @meganrogge<https://github.com/meganrogge> Recently we have been working on adopting the EditContext API (https://developer.mozilla.org/en-US/docs/Web/API/EditContext_API) within VS Code. The EditContext is a new DOM property that can be set on DOM elements which decouples text input from the textual mutations of the DOM element. Essentially when the user focuses a DOM element on which an EditContext is set and types, the EditContext fires 'textupdate' events, and it is up to the user to mutate the DOM element with the changes from this event. There are several reasons why we have adopted this API: * This API has allowed us to greatly simplify the code which handles text input events. * This API has allowed us to close numerous IME related bugs * This API can allow us to emit customized typing information from the input events We have an experimental setting which enables the EditContext API with ID editor.experimentalEditContextEnabled. We would like to ask @jooyoungseo<https://github.com/jooyoungseo> and @rperez030<https://github.com/rperez030> if when you have time you could try the setting with a screen reader and let us know if you see any issues on typing in the various inputs of VS Code (could be the editor, the panel chat input, the SCM view, the quick input, ie any input that accepts text insertions). We would like to gather feedback from screen reader users before enabling this setting by default. - Reply to this email directly, view it on GitHub<#229051> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJH5KGXL4TYU3I5ZCMMZUR3ZXKUOXBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLKJTGE3DQMJTGM3DJJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVI3TIMRYGM2DKOJVGSSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44UQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKBUGE4DQMJZGAYIFJDUPFYGLJLJONZXKZNFOZQWY5LFVIZDKMZVHE4TGMZQGWBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJGMYTMOBRGMZTMNECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNZUGI4DGNBVHE2TJJ3UOJUWOZ3FOKTGG4TFMF2GK>. You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[jooyoungseo]

NVDA does not seem to support this new editor mode; word-by-word navigation with JAWS is not reliable. Sorry for the brevity. This is my initial and quick testing results.