Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.experimentalEditContextEnabled makes the Keyboard Shortcuts setting panel unusable #228104

Closed
tamuratak opened this issue Sep 10, 2024 · 6 comments · May be fixed by #228588
Closed

editor.experimentalEditContextEnabled makes the Keyboard Shortcuts setting panel unusable #228104

tamuratak opened this issue Sep 10, 2024 · 6 comments · May be fixed by #228588
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium editor-edit-context upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@tamuratak
Copy link
Contributor

Version: 1.94.0-insider
Commit: 8b7eb51
Date: 2024-09-10T05:04:21.546Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 22.6.0

Steps to Reproduce:

  1. Set "editor.experimentalEditContextEnabled": true
  2. Open the Keyboard Shortcuts setting panel.
  3. We cannot type at the search bar of the panel.
@tamuratak tamuratak changed the title editor.experimentalEditContextEnabled makes Keyboard Shortcuts setting panes unusable editor.experimentalEditContextEnabled makes the Keyboard Shortcuts setting panel unusable Sep 10, 2024
@jrieken jrieken assigned hediet and aiday-mar and unassigned jrieken Sep 10, 2024
@aiday-mar
Copy link
Contributor

Another thing that happens is that when you open the settings editor. Then open the keyboard shortcuts and try to type in the input of the keyboard shortcuts nothing happens. The input of the settings editor is instead updated even though the keyboard shortcuts pane is focused.

@aiday-mar
Copy link
Contributor

In fact something weird happens. There is an edit context associated to the settings editor input which sends text update events. When we switch to the keyboard shortcuts editor and type int the input, despite the keyboard shortcuts input being clearly focused, the settings editor edit context keeps firing text update events. This can be seen in the following screen recording, where I record on the text update event, the currently focused element (which is the keyboard shortcuts input) and the dom element corresponding to the edit context which is currently firing the text update event (here it is the settings editor).

Screen.Recording.2024-09-13.at.16.47.50.mov

@aiday-mar
Copy link
Contributor

This seems to happens with the quick pick as well as with the search widget. These all share a common point in that they use the InputBox widget.

@aiday-mar
Copy link
Contributor

This issue does not reproduce on https://insiders.vscode.dev which is on the chromium version of your browser (so for me on the latest). This seems to be a chromium bug that we are seeing because we are on Electron 30.

@aiday-mar aiday-mar added chromium Issues and items related to Chromium bug Issue identified by VS Code Team member as probable bug upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Sep 18, 2024
@aiday-mar
Copy link
Contributor

I have used the google bisect tool and found the last revision with the bug and the first revision with the fix, namely:

1317063 (known bad)
1317085 (first known good)

After checking the URL: https://chromium.googlesource.com/chromium/src/+log/8850873881a39a3a4c0f1b2fec31c1256de54f66..396f34f201afa06c5530d4e0cf12a91c19847352

The commit that fixes the issue seems to be:

https://chromium.googlesource.com/chromium/src/+/3ee998b6e2fc6705ff40365ec5f5aad93a92b39d

cc @deepak1556

This issue will be closed.

@deepak1556
Copy link
Collaborator

Thanks for the bisect, the commit was first merged into 128.0.6548.0 which will be available with our Electron 32 version bump next month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium editor-edit-context upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants